Question

83

JavaScript splice function inside foreach loop decrements index

rated 0 times [ 87] [ 4] / answers: 1 / hits: 21400 / 11 Years ago, sun, june 2, 2013, 12:00:00

$scope.clearCompleted = function()

        {

            angular.forEach($scope.todos, function(todo, i)

            {

                if(todo.done)

                {

                    $scope.todos.splice(i, 1);

                }

            });



            if($scope.todos.length == 0)

            {

                $scope.isEmpty = true;

            }

        }

This is my code to delete the 'done' todos from an array,
but when two todos after each other are removed, it only removes the second.
I think it's because the splice function resets and the returns the spliced array.

Answers

Only authorized users can answer the question. Please sign in first, or register a free account.

leilanichasel

Add To Favorites

Follow

Total Points: 224

Total Questions: 112

Total Answers: 94

Location: Angola

Member since Wed, Apr 13, 2022

2 Years ago

answered 11 Years ago tiasavannahw · Accepted Answer

You splice elements from the array, which you iterated, therefore indexes in todos reduced. Sorry for my bad english.

var notDonedTodos = [];

angular.forEach($scope.todos, function(todo, i)

{

    if(!todo.done)

    {

       notDonedTodos.push(todo);

    }

});



$scope.todos = notDonedTodos;