Question

55

Cannot read property 'id' of undefined when parsing an array declared in a factory

rated 0 times [ 61] [ 6] / answers: 1 / hits: 82765 / 9 Years ago, fri, february 27, 2015, 12:00:00

I am building a basic app (with MEAN web frameworks and node webkit) in order to understand angularjs better.

Here is the content of my notificationFactory.js

function notificationFactory() {



    var fooMessages = [



        {

            id: 4,

            dismissable: true,

            name: fooooBaaar,

            function: '',

            showInTopBar: false,

            priority: high,

            icon: 'fooIconBarBarBar',

            topBarIcon: 'fooIconIconIcon'

        },



        {

            id: 3,

            dismissable: true,

            name: foofooBarBar,

            function: '',

            showInTopBar: false,

            priority: high,

            icon: 'fooIconfooIcon',

            topBarIcon: 'IconIconIcon'

        },



        {

            id: 2,

            dismissable: true,

            name: foo foo,

            function: '',

            showInTopBar: false,

            priority: high,

            icon: 'fooBaaaaaar',

            topBarIcon: 'IconFooIcon'

        },



        {

            id: 1,

            dismissable: true,

            name: foo,

            function: '',

            showInTopBar: false,

            priority: high,

            icon: 'fooIcon',

            topBarIcon: 'fooIconIcon'

        },

    ]



    fooMessages.TopBarDismiss = function (message) {

        $.each(fooMessages, function (i, v) {

            if(v.id = message.id) {

                fooMessages.splice(i,1);

            }

        });



    }



    return fooMessages;



}



angular.module('fooDemo').factory('notificationFactory', notificationFactory);

I call the TopBarDismiss() function in an HTML template using:

<div class=fooDismiss ng-click=notificationFactory.TopBarDismiss(message)>Dismiss</div>

When I check out the console after pressing my Dismiss button, I get this:

 TypeError: Cannot read property 'id' of undefined

at notificationFactory.js:94

at Function.m.extend.each (jquery.min.js:2)

at Array.fooMessages.TopBarDismiss (notificationFactory.js:93)

at fb.functionCall (angular.js:10847)

at angular-touch.js:472

at k.$get.k.$eval (angular.js:12702)

at k.$get.k.$apply (angular.js:12800)

at HTMLDivElement.<anonymous> (angular-touch.js:471)

at angular.js:3097

at r (angular.js:325)angular.js:10072 (anonymous function)angular.js:7364 $getangular.js:12802 $get.k.$applyangular-touch.js:471 (anonymous function)angular.js:3097 (anonymous function)angular.js:325 rangular.js:3096 r.triggerHandlerangular.js:3111 S.(anonymous function)angular-touch.js:453 (anonymous function)angular.js:2853 (anonymous function)angular.js:325 rangular.js:2852 c

so it must be the

$.each(fooMessages, function (i, v) {

    if (v.id == message.id) {

    } 

});

part that is quite horrible.

Can you, guys, spot the error for me, please?

Answers

Only authorized users can answer the question. Please sign in first, or register a free account.

elishaannac

Add To Favorites

Follow

Total Points: 28

Total Questions: 97

Total Answers: 101

Location: Samoa

Member since Mon, Nov 8, 2021

3 Years ago

elishaannac questions

1 Getting warning in 'eslint-plugin-react-settings' while running eslint

Fri, Mar 11, 22, 00:00, 2 Years ago

1 React-router-dom (v6) with Framer Motion (v4)

Sun, Dec 5, 21, 00:00, 3 Years ago

1 can I display custom javascript in streamlit web app

Mon, Jun 14, 21, 00:00, 3 Years ago

1 Handling state with multiple checkboxes in React Native

Mon, Jul 22, 19, 00:00, 5 Years ago

1 How to add custom row on the end of the table (b-table)

Mon, Jul 8, 19, 00:00, 5 Years ago

View All

answered 9 Years ago dezmondhumbertob · Accepted Answer

First, as said in the comments, you need to make sure the message object passed is really the one you're looking for.

Then, if you just want to splice you can do:

fooMessages.TopBarDismiss = function (message) {

        var index;

        for (var i = 0; i < fooMessages.length; i++) {

            if(fooMessages[i].id == message.id) {

                index = i;

                break;

            }

        }

        if (index) {

              fooMessages.splice(index,1);

        } 



}