Question

76

< div> onClick not working?

rated 0 times [ 82] [ 6] / answers: 1 / hits: 36546 / 10 Years ago, wed, july 16, 2014, 12:00:00

Iam printing some content using php code inside html but, when i tried to click on that div its not calling the function in onClick ??

Here is my php code

 echo '<div class=col-sm-12 col-xs-12  ><div class=row >';

echo '<div class=col-sm-10 onClick=openUrlInNewTab('.$myarray['Job']['link'].');><h3>';

echo  $myarray['Job']['title'].</h3></div></div></div>;

this is resulting html code in view source of browser

<div class=col-sm-12 col-xs-12 >

 <div class=row  >

  <div class=col-sm-10  onClick=openUrlInNewTab(www.example.com); >

    <h3>Can you Code? </h3>

  </div>

 </div>

</div>

and here is my function in html page

    function openUrlInNewTab(url) {

// div click is not reaching  here

     alert(url); 

     window.open(url, _blank);

}

Answers

Only authorized users can answer the question. Please sign in first, or register a free account.

quentinaveryb

Add To Favorites

Follow

Total Points: 102

Total Questions: 100

Total Answers: 93

Location: Colombia

Member since Mon, May 2, 2022

2 Years ago

quentinaveryb questions

1 How to use annotation layer in PDF.js?

Thu, Aug 6, 20, 00:00, 4 Years ago

1 Cannot assign to read only property of #< Object> using React with Recoil

Sat, Jul 18, 20, 00:00, 4 Years ago

1 Strapi JWT token lifetime?

Fri, Jul 17, 20, 00:00, 4 Years ago

1 What is the difference between async await and a regular fetch?

Tue, Feb 4, 20, 00:00, 4 Years ago

1 How do I include a JavaScript variable in an HTML header?

Mon, Aug 12, 19, 00:00, 5 Years ago

View All

answered 10 Years ago campbelljonahb · Accepted Answer

You should use single quotes.

Instead of

<div class=col-sm-10  onClick=openUrlInNewTab(www.example.com); >

you should have

<div class=col-sm-10  onClick=openUrlInNewTab('www.example.com'); >

If you put double quotes inside double quotes it simple won't work.

So in PHP you should change:

 echo '<div class=col-sm-10 onClick=openUrlInNewTab('.$myarray['Job']['link'].');><h3>';

into

echo '<div class=col-sm-10 onclick=openUrlInNewTab(''.$myarray['Job']['link'].'');><h3>';

EDIT

One extra thing. If you want this url open in your browser, you should rather add http:// before www.example.com

Sample working HTML code:

<!DOCTYPE html>

<head>

    <meta charset=utf-8 />

</head>

<body>

<div class=col-sm-12 col-xs-12 >

 <div class=row  >

  <div class=col-sm-10  onclick=openUrlInNewTab('http://www.example.com'); >

    <h3>Can you Code? </h3>

  </div>

 </div>

</div>

          <script>

    function openUrlInNewTab(url) {

// div click is not reaching  here

     alert(url); 

     window.open(url, _blank);

}

</script>

</body>

</html>