Question

170

JavaScript getAttribute not working

rated 0 times [ 172] [ 2] / answers: 1 / hits: 17361 / 14 Years ago, tue, january 4, 2011, 12:00:00

var objects = document.getElementsByTagName('object');

for (var i=0, n=objects.length;i<n;i++) {

    objects[i].style.display='none';

    var swfurl;

    var j=0;

    while (objects[i].childNodes[j]) {

    if (objects[i].childNodes[j].getAttribute('name') == 'movie') {

            /* DO SOMETHING */ 

    }

    j++;

}

    var newelem = document.createElement('div');

    newelem.id = '678297901246983476'+i;

    objects[i].parentNode.insertBefore(newelem, objects[i]);

    new Gordon.Movie(swfurl, {id: '678297901246983476'+i, width: 500, height: 400});

}

It says that getAttribute is not a function of childNodes[j]. What's wrong? I don't see the point.

Answers

Only authorized users can answer the question. Please sign in first, or register a free account.

havenbilliec

Add To Favorites

Follow

Total Points: 324

Total Questions: 106

Total Answers: 94

Location: Pitcairn Islands

Member since Fri, Oct 15, 2021

3 Years ago

havenbilliec questions

1 Uncaught ReferenceError: process is not defined / Line 0: Parsing error

Thu, Mar 3, 22, 00:00, 2 Years ago

1 React Big Calendar - Is it possible to click on a day and retrieve a list of events on that day?

Fri, Feb 11, 22, 00:00, 2 Years ago

1 Warning: A component is changing a controlled input to be uncontrolled in React js

Fri, May 7, 21, 00:00, 3 Years ago

1 Error: Cannot find module nuxt.js, why my app don't start?

Wed, Apr 7, 21, 00:00, 3 Years ago

1 Redirecting to another html page after successful login attempt

Wed, Nov 25, 20, 00:00, 4 Years ago

View All

answered 14 Years ago everardo · Accepted Answer

Check the nodeType property is 1 (meaning the node is an element) before calling element-specific methods such as getAttribute(). Also, forget getAttribute() and setAttribute(): you almost never need them, they're broken in IE and they don't do what you might think. Use equivalent DOM properties instead. In this case:

var child = objects[i].childNodes[j];

if (child.nodeType == 1 && child.name == 'movie') {

    /* DO SOMETHING */ 

}